Skip to content

Don't recommend setting Keywords in PackageInfo.g#55

Open
fingolfin wants to merge 1 commit into
masterfrom
mh/Keywords
Open

Don't recommend setting Keywords in PackageInfo.g#55
fingolfin wants to merge 1 commit into
masterfrom
mh/Keywords

Conversation

@fingolfin

Copy link
Copy Markdown
Member

This field seems to of at best marginal utility, if it has any. To the best of my knowledge, the only thing it is used for is by the Cite command, to insert it as a keywords field into the generated bib data. But is that useful? For what?

All in all, I feel we might be better off not advertising this field anymore, and also phasing it out in the GAP documentation. Simply because a feature where we can't explain what it is good for is not helping anyone (in fact this PR is triggered by me once again wondering "but what should I even put there?" for this field in a new package. If I knew a usecase, it would surely inform that decision. But I know none (I have no idea what "keywords" in a bib entry are good for either).

The alternative is to keep it, but then also document all known uses of the field, i.e., in Cite, unless someone knows other uses?

This field seems to of at best marginal utility, if it has any.
To the best of my knowledge, the only thing it is used for is
by the Cite command, to insert it as a `keywords` field into the
generated bib data. But is that useful? For what?

All in all, I feel we might be better off not advertising this
field anymore, and also phasing it out in the GAP documentation.

The alternative is to keep it, but then also document all known
uses of the field, i.e., in `Cite`, unless someone knows other
uses?
@codecov

codecov Bot commented May 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.06%. Comparing base (bd6d621) to head (4bba70c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   62.09%   62.06%   -0.03%     
==========================================
  Files           3        4       +1     
  Lines         153      203      +50     
==========================================
+ Hits           95      126      +31     
- Misses         58       77      +19     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ThomasBreuer ThomasBreuer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The (mandatory) fields intended for describing the contents of a package are subtitle and abstract, they appear on the webpage about GAP packages, and can be used for searching. (The names of most packages do not give any hint about the topic of the package.)

Apparently keywords is not used in the package webpages. I think the idea had been that keywords could be used as an additional way to explain what a package is about, in analogy to mathematical papers (but not in the sense of the AMS subject classification). Note that subtitle is requested to "fit on one line", i. e., to be very short.

If the keywords field gets deprecated then the main place to be changed is the section "The PackageInfo.g File" in the Reference Manual, and a line in ValidatePackageInfo can get removed.

@olexandr-konovalov

Copy link
Copy Markdown
Member

@fingolfin thanks for providing justification - but maybe this field should be used to search for a package at https://www.gap-system.org/packages/ instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants